Skip to content

QNN Backend: Enable QualComm SM8850 targets #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

QNN Backend: Enable QualComm SM8850 targets #15987

merged 1 commit into from
Dec 2, 2025
+7 −0

Conversation

@yinrun
Copy link
Contributor

@yinrun yinrun commented Nov 26, 2025

Add SM8850 for QualComm Snapdragon 8 Elite Gen 5.

Summary

Fixes #15986

Test plan

python -m examples.qualcomm.oss_scripts.llama.llama -b build-android -m SM8850 --temperature 0 --model_mode kv --max_seq_len 512 --prefill_ar_len 64 --decoder_model qwen3-0_6b --prompt "你好，请介绍一
下人工智能" --compile_only

@yinrun yinrun requested a review from cccclai as a code owner November 26, 2025 06:23
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15987

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 105 Pending

As of commit 31fbc00 with merge base 1864fb0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Nov 26, 2025

Hi @yinrun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2025
shewu-quic
shewu-quic reviewed Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Could you please also add SM8850 in README.md?

Thanks

@cccclai
Copy link
Contributor

cccclai commented Nov 26, 2025

Thank you for contributing! Can you also sign the CLA as described in the comment here

Hi @yinrun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@yinrun
Copy link
Contributor Author

yinrun commented Nov 27, 2025 •
edited
Loading

Thanks for contribution. Could you please also add SM8850 in README.md?

Thanks

Okay, I have already add "Snapdragon 8 Elite Gen 5" in section Supported Chipset.
image

@shewu-quic

@yinrun
Copy link
Contributor Author

yinrun commented Nov 27, 2025 •
edited
Loading

and we don't seem to have one on file for you.

It's done. Thanks for the reminder.

image

@cccclai

@yinrun
Copy link
Contributor Author

yinrun commented Dec 1, 2025

image

Excuse me, I don't know what I can do about such problems. @cccclai

@cccclai
Copy link
Contributor

cccclai commented Dec 1, 2025

image Excuse me, I don't know what I can do about such problems. @cccclai

I think our CI was failing for the past week but it should be re-enabled now. Can you rebase and update the PR?

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

QNN Backend: Enable QualComm SM8850 targets pytorch#15986
31fbc00 
Add SM8850 for QualComm Snapdragon 8 Elite Gen 5.
@yinrun yinrun force-pushed the enable_qnn_sm8850 branch from 0aa8c63 to 31fbc00 Compare December 2, 2025 01:09
@cccclai cccclai merged commit 2ebed88 into pytorch:main Dec 2, 2025
141 checks passed
AdrianLundell pushed a commit to AdrianLundell/executorch that referenced this pull request Dec 2, 2025
@yinrun @AdrianLundell
QNN Backend: Enable QualComm SM8850 targets (pytorch#15987)
f501e33 
Add SM8850 for QualComm Snapdragon 8 Elite Gen 5.

### Summary
Fixes pytorch#15986


### Test plan
python -m examples.qualcomm.oss_scripts.llama.llama -b build-android -m
SM8850 --temperature 0 --model_mode kv --max_seq_len 512
--prefill_ar_len 64 --decoder_model qwen3-0_6b --prompt "你好，请介绍一
下人工智能"   --compile_only

Co-authored-by: lvyinrun <lvyinrun@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

+1 more reviewer

@shewu-quic shewu-quic shewu-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QNN] QualComm latest SM8850 doesn't support

3 participants

@yinrun @cccclai @shewu-quic